Initial high level changes from `moving_mesh`
Hi, I'm trying to split up the changes of the moving_mesh
branch into reviewable chunks.
This is the first attempt. It may still seem like a lot of changes, but most of the line changes are actually from removing all references to the old moving mesh scheme and replacing its hydro files with the files from the empty hydro scheme (as placeholders).
This merge request mainly incorporates the following changes:
-
doc
: add initial documentation for moving mesh hydro. -
configure.ac
: update name of hydro scheme, check for presence of GMP. -
makefile.am
: remove references to old shadowfax headers and add new headers. -
swift.c
: add flags indicating we are running with moving-mesh hydro instead of sph. -
engine.c
andengine.h
: Initalize and communicate necessary fields oncell_grid
to be able to create moving mesh tasks at right level. -
cell_grid.h
: add new type of cell, that will eventually hold the geometry information. -
hydro/Shadowswift
: replace old shadowfax scheme with empty hydro scheme (for now). -
tests
: remove references to old shadowfax scheme
From there I also had to add the following:
-
procy.h
,proxy.c
,cell_pack.c
: Add functions for communicating extra cell information for moving mesh needen during engine setup. -
cell.h
andcell.c
: add functions to compute basic cell-level information for moving mesh needed during engine setup. -
shadowswift/voronoi.h
: placeholder voronoi struct and empty functions that needed definitions. -
space.h
andspace.c
: define particle number threshold for grid construction level (needed by new functions incell.c
).
At this point, the code can succesfully finish a dry run when compiled with --with-hydro=shadowswift --with-riemann-solver=hllc --enable-debugging-checks=yes
, both with and without MPI.
However, since the hydro scheme is empty, no timesteps can (and should) be performed. The code crashes in space_first_init_parts_mapper()
with error Invalid value of smoothing length for part 0 h=0.000000e+00
.
Does this seem like a sensible first step?
Thanks, Yolan
Merge request reports
Activity
assigned to @yuyttenhove
requested review from @matthieu
added 4 commits
-
3effbc77...50906bac - 2 commits from branch
master
- 1f5ed0ac - Run moving mesh hydro also with --run
- 39c1262d - Merge branch 'master' into moving_mesh_merging
-
3effbc77...50906bac - 2 commits from branch
added Moving mesh label
- Resolved by Matthieu Schaller
Thanks! Going by chunks will help for sure. I'll have a look in the coming days.
From a quick look: What is the rational for the changes in
swift.c
?
- Resolved by Matthieu Schaller
Do you maybe have an overview document somewhere describing the general concepts and where you are going to implement what in the code?
- Resolved by Matthieu Schaller
- Resolved by Yolan Uyttenhove
- Resolved by Yolan Uyttenhove
- Resolved by Yolan Uyttenhove
- Resolved by Yolan Uyttenhove