Change the clang formatting version number from 13 to 18.

I can then also update the jenkins tool to use the newer llvm module on cosma.

added code health label

assigned to @pdraper

Actually was just reviewing the use of modules in Jenkins. Will take this on as part of that work.

!1962 (merged) looks relevant to GCC 14 along with some warnings about argument ordering in calloc calls (which make absolutely no difference to anything in reality).

I did indeed fix some calloc calls as gcc 14 is the new new default on my laptop. I think these are now fine.

There are also a few things I don't like in the default clang-18 style so I am looking at tweaking things a bit before pushing the changes on the code side.

added 1 commit

• 0421168f - Applied the updated formatting script. Made some small style changes in places...

Compare with previous version

added 1 commit

• f9c47b35 - Five more cases of one-line loops now written with curlies

Compare with previous version

The main change I did not like was that clang changed

for(;;)
  ;

to

for(;;);

in the few cases where we just needed to loop to reach the termination condition.

Having all on the same line is confusing. Arguably, so was having it on two lines so I replaced all instances with an empty block.

What do you think?

Not sure I like either really. Your fix of documenting the empty loop looks better anyway.

merged

mentioned in commit 930c91f7