Skip to content
Snippets Groups Projects

Draft: Reduce the number of activated comms

Closed Matthieu Schaller requested to merge activate_fewer_comms into master
1 unresolved thread

Possible improvement:

  • Report whether cell_unskip_hydro_tasks() actually activated anything.
  • Only activate the related MPI comms if we indeed did.

The logic is that if you recurse a few levels on the subtask, you may not have any two sub-cells that touch over the border and are active. You may as well not run the comm in that case. You probably want the task itself (i.e. the subpair) still as it will deal with the dependencies and will abort quickly anyway.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
883 893 /* Do we need to sort the cells? */
884 894 cell_activate_hydro_sorts(ci, sid, s);
885 895 cell_activate_hydro_sorts(cj, sid, s);
896
897 activated_task = 1;
  • Narrator: This does not work. Code hangs.

  • Please register or sign in to reply
    Loading