Fix radiated energy saved to statistics for EAGLE cooling.

(cherry picked from commit 340658c0)

I think the radiated energy stored in xp.cooling_data was incorrect for the EAGLE cooling scheme.

The variable cooling_du_dt actually stores the total du_dt (hydro + cooling), so the hydro_du_dt needs to be subtracted when computing the radiated energy.

Some examples (from CoolingSedovBlast3D):

	Without fix	With fix
Sphenix:
Gizmo-MFV:

added EAGLE bug labels

requested review from @matthieu

assigned to @yuyttenhove

Maybe it's also worth moving the update of the radiated energy into the hydro schemes, since for Gizmo and moving mesh specifically, we can compute the radiated energy more accurately there...

assigned to @matthieu and unassigned @yuyttenhove

requested review from @jborrow and removed review request for @matthieu

Great, thanks for fixing all these! I suspect the PS2020 cooling has the same mistake.

That is certainly an interesting bug! Thanks for fixing this. As Matthieu says, I think all the cooling schemes probably have this problem too. Good to see the total energy is now a flat line...

approved this merge request

I quickly checked and from looking at the code, the other schemes seem to be doing the right thing (each in their own slightly different, but equivalent way however), except the QLA schemes which simply do not store the radiated energy.

approved this merge request

Thanks for checking.

merged

mentioned in commit 24674a02