Upgrade to FOF to treat some types differently

• Supersedes !1798 (closed).
• Implements #820 (closed).
• Implements #872 (closed).
• Fixes an old bug in the calculation of the linking length when the DM particle masses are not constant.
• Fixes an old bug which would crash the code at the end of a stand-alone FOF call.

Some important changes to the FOF algorithm.

We create two kinds of particles: linkable and attachable:

• The linkable ones behave as before. They build groups with each other.
• The attachable ones can only be linked to a linkable. (i.e. no attach-to-attach links allowed). They can't be root. They attach to the nearest linkable. Max distance for search is set by the linking length.

The two categories are specified at runtime in the parameter file.

The use case is to run FOF on the DM only and then attach the gas/stars/BHs to the nearest DM particle they find. With some minor caveats, this is what other FOF codes do.

The strategy is as follows:

• Perform a regular FOF search only involving the linkables.
• Same over MPI and construct the array of possible links.
• Launch a new pass over the particle where each attachable identifies the nearest linkable. Store that info.
• Once the pass is done, loop over the local attachables and act:
  • If the nearest linkable is also local --> update the arrays
  • If the nearest linkable is foreign --> create a new link
• Process all the links as before
• Compute group properties.

Additional improvements:

• Do not attempt to write subgrid info in the snapshots produced as it hasn't been read in.

Todo:

• #872 (closed).
• Can we skip the regular engine_maketasks() in the first engine_rebuild()? --> No. Need the comms.
• Update all relevant parameter files.
• Threadpoolize some of the new loops.
• Update the docs.

added enhancement feature request labels

assigned to @matthieu

mentioned in merge request !1798 (closed)

added 1 commit

• 22ed32e7 - Small cosmetic changes

Compare with previous version

changed the description

added 1 commit

• 70939a1d - Tweak the i/o code to not write out the subgrid properties when running a stand-alone FOF call

Compare with previous version

added 1 commit

• c02efb8e - Applied formatting script

Compare with previous version

marked this merge request as ready

added 1 commit

• 314835b1 - Fix typo in parallel_io changes

Compare with previous version

changed the description

added 2 commits

• 885e5939 - Do not change the error function
• cdc99bdd - Merge branch 'attach_in_post' of gitlab.cosma.dur.ac.uk:swift/swiftsim into attach_in_post

Compare with previous version

added 1 commit

• b02fdc76 - Applied code formatting

Compare with previous version

added 1 commit

• 97ee305f - C code formatting

Compare with previous version

changed the description

changed the description

changed the description

changed the description

changed the description

@crowe this should run out of the box on COLIBRE. The code will not try to write the subgrid properties to the snapshots so no problem there. It will still try to write some of the problematic particle properties but you can eliminate that at runtime via an output selection file (see the online doc).

changed the description

added 24 commits

• 97ee305f...133256b6 - 23 commits from branch master
• 0f682533 - Merge branch 'master' into attach_in_post

Compare with previous version

requested review from @jwillis

added 1 commit

• 935e8965 - Updated all the relevant parameter files

Compare with previous version

marked the checklist item Update all relevant parameter files. as completed

marked the checklist item Threadpoolize some of the new loops. as completed