Skip to content
Snippets Groups Projects

Draft: Streamlined MAGMA2 implementation

Open Matthieu Schaller requested to merge MAGMA2_matthieu into master

This is a reimplementation of the MAGMA2 branch with:

  • Simpler symmetric matrix handling
  • Only 1st order reconstruction of v and u.
  • Only basic viscosity and diffusion terms as in the Rosswog 2020 implementation

Questions:

  • Do we need more advanced terms? SPHENIX-like? Or the Rosswog entropy-based viscosity switch?
  • What implementation do we want? Traditional or Gasoline?

Todo:

  • Document the matrix stuff
  • 1D and 2D cases
  • Scale-factors
  • Strange corner cases (e.g. no ngb)
  • Tests in galaxy settings
  • Properly implement the symmetric functions.
  • Fix documentation. It still mentions Minimal and SPHENIX in places.
Edited by Matthieu Schaller

Merge request reports

Ready to merge by members who can write to the target branch.

Merge details

  • The source branch is 14 commits behind the target branch.
  • 0 commits and 1 merge commit will be added to .
  • Source branch will not be deleted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading