skip particle timestep data collection in space_split.c when running without RT
Merged
requested to merge rt_skip_particle_timestep_data_collection_in_space_split_when_running_without_RT into master
Issue reported by Yolan in !1749 .
For new progeny cells, when running without RT, particle time bins are zero. Then those time bins get collected to determine the time step vars for the progeny cell, leading to wrong results.
This oughtta fix it, but I haven't had time to test it yet.
ToDo's Mladen:
-
Testing this fix -
Check that there aren't other places where this could be an issue -
run the bloody formatter
Edited by Mladen Ivkovic
Merge request reports
Activity
added bug radiative transfer labels
assigned to @mivkov
mentioned in merge request !1749
added 27 commits
-
529d1a84...47c1d1c9 - 26 commits from branch
master
- 55dd8c2a - skip particle timestep data collection in space_split.c when running without RT
-
529d1a84...47c1d1c9 - 26 commits from branch
added 4 commits
-
55dd8c2a...c029e413 - 2 commits from branch
master
- 728a6cb2 - skip particle timestep data collection in space_split.c when running without RT
- ea7950dc - applied formatting tool
-
55dd8c2a...c029e413 - 2 commits from branch
requested review from @yuyttenhove
Happy to merge if @yuyttenhove is too.
mentioned in commit 3f596584
Please register or sign in to reply