Skip to content
Snippets Groups Projects

Fixed the minimal SPH hydro version

Merged Fixed the minimal SPH hydro version
fix_minimal into master
Merged Matthieu Schaller requested to merge fix_minimal into master

Fix to #148 (closed). The code now runs without segfaulting when using the minimal SPH hydro code. Results are not great (by design) as the model is really poor (but simple).

Changes are:

  • A missing initialisation in engine_init_particles().
  • A mistake in the calculation of the du/dt term.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
src/engine.c
1904 1904
1905 1905 if (e->nodeID == 0) message("Initialising particles");
1906 1906
1907 engine_prepare(e);
1908
1907 1909 /* Make sure all particles are ready to go */
1908 1910 /* i.e. clean-up any stupid state in the ICs */
1909 1911 if (e->policy & engine_policy_hydro) {
1910 space_map_cells_pre(s, 1, cell_init_parts, NULL);
  • Peter W. Draper
    Peter W. Draper @pdraper
    Owner

    @matthieu these changes to engine.c break cell initialisation when the cells are split as they do not have any xparts (seems to only be seen when running on the CosmoVolume with a few MPI ranks). Can you review these please and submit a fix.

  • Matthieu Schaller
    Matthieu Schaller @matthieu
    Author Owner

    Arggh... Ok, that needs reverting then. engine_prepare() should again be called after space_map_cells_pre().

    I'll work again on fixing the minimal case.

    • Please register or sign in to reply