Upgrade the code formatting tool requirement to clang v.13.

This upgrades the code formatting tool requirement to version 13 of clang (October 2021). I think it's installed on cosma so it should not be an issue there.

added code health label

requested review from @bvandenbroucke

assigned to @pdraper

I am not sure clang-format-14 is already sufficiently supported to make this change.

My Fedora desktop has clang-format-13 and I have no easy way to upgrade that version, at least not until the forced end of year upgrade of the OS. It seems to be the default on my freshly installed Ubuntu 22.04, but that also supports versions 11-13. So I would prefer version 13 if that is also an option.

Ok, if standard machines we use are not using this version that might be unwise.

added 7 commits

• 4031d5b9...904b8643 - 5 commits from branch master
• 7d457b79 - Merge branch 'master' into clang-14
• c52c0b14 - Revert to clang-format-13 which is present on more machines

Compare with previous version

changed title from Upgrade the code formatting tool requirement to clang v.14. to Upgrade the code formatting tool requirement to clang v.13.

changed the description

Looks like it results in the same formatting changes anyway so let's be safe and use 13.

Great. Another issue is that clang-format-13 is simply called clang-format on my desktop. Is there an easy way to check the version without relying on a version suffix?

If not, I am happy to use an alias for now.

I think the answer is not very robustly as the version strings are a mixed bunch. I see Ubuntu clang-format version 14.0.0-1ubuntu1 and Ubuntu clang-format version 11.1.0-6 just on my desktop. The way you are supposed to do this is by setting the environment variable:

export CLANG_FORMAT_CMD=clang-format

or whatever. That overrides the one defined in the script as described at the head.

I've built an llvm/13.0.0 module on COSMA and that worked. So all looks ready to go.

merged

mentioned in commit dedf808f