Skip to content
Snippets Groups Projects

Do not activate stars pair tasks and communications for pairs that recurse to zero work.

Closed Bert Vandenbroucke requested to merge do-not-activate-empty-star-pairs into master

Because of recursion, pair tasks can reduce to zero work, if the progeny pairs on a lower level have no active particles. Nonetheless, these pair tasks are still activated, along with all the required communications if these pairs span domain boundaries.

This MR adds an additional check (basically a copy of cell_activate_subcell_stars_tasks that does not activate any tasks) that checks whether any active pairs are left after recursion. It then only activates the pair tasks and communications if this is the case. This should reduce the number of active star pair tasks and communications in large volume simulations with a small number of stars per cell.

TODO:

  • also update the activation code in cell_unskip_star_tasks
Edited by Bert Vandenbroucke

Merge request reports

Closed by Bert VandenbrouckeBert Vandenbroucke 3 years ago (Dec 16, 2021 2:42pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading