Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 54
    • Issues 54
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 18
    • Merge requests 18
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !1438

fixed IACT dependency issue (sink, bh, star, RT)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Mladen Ivkovic requested to merge fix_771 into master Sep 30, 2021
  • Overview 53
  • Commits 13
  • Changes 2

Fixes #771 (closed).

Here's a pre-fix dependency plot of the step where my test in #771 (closed) crashed:

dependency_graph_2-pre-fix-with-RT

And one after:

dependency_graph_2

We have more stars_in and stars_out unlocks now. Also noteably this fixes an issue I wanted to tackle next: Now the hydro-type tasks of the RT section (gradient and transport) have the same number of unlocks as the hydro tasks themselves; and the star-type tasks of the RT section (inject) have the same number of unlocks as the star tasks. So this'll get two birds with one stone, at least for me.

Edited Oct 13, 2021 by Mladen Ivkovic
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_771