First version of main() using a parameter file to get constants.
That's pretty big but does not touch the physics, the parallelisation nor MPI.
In brief:
- Latest version of the parser from @jwillis
- More uniform name of functions in the unit module.
- Added the ability for the
engine
,space
,unit
andpartition
objects to construct themselves from a parsed parameter file. - Added an example yaml file with full documentation.
- Added yaml files and run scripts for the Sedov, Sod and uniform examples.
- General tidying of the
main()
. - Dropped the dependency on z-lib which we don't use.
- Updated the README to reflect the new command-line parameters.
- Cleaned-up the
main()
such that the only command-line parameters read in are policies and debugging options. - Added the option to do a 'dry run'. This reads the parameter file, allocates the memory required by the ICs but does not read anything and constructs a space and engine. This allows us to check the validity of a given parameter file.
Happy to guide you through the changes if need be.
This closes #81 (closed).
Merge request reports
Activity
Reassigned to @pdraper
Added 1 commit:
- b90bd94b - Fixed sscanf() mistake in the parsing of doubles.
Just fixed the parsing of doubles problem.
@pdraper I have added run.sh scripts in the Sedov, Sod and Uniform box cases. Do you think we still need the 'global' run.sh script ?
Hmm, here's an odd one. When I run:
../swift sodShock.yml
that looks OK, but:
../swift -s sodShock.yml
outputs:
[00002.0] engine_init_particles: Initialising particles [00003.3] runner_doghost: Smoothing length failed to converge on 1 particles. [00003.4] runner_doghost: Smoothing length failed to converge on 2 particles. [00003.4] runner_doghost: Smoothing length failed to converge on 2 particles. [00003.4] runner_doghost: Smoothing length failed to converge on 1 particles. [00003.5] runner_doghost: Smoothing length failed to converge on 1 particles. [00003.5] runner_doghost: Smoothing length failed to converge on 2 particles. [00003.5] runner_doghost: Smoothing length failed to converge on 1 particles. [00003.6] runner_doghost: Smoothing length failed to converge on 1 particles. [00003.6] runner_doghost: Smoothing length failed to converge on 2 particles. [00003.6] runner_doghost: Smoothing length failed to converge on 1 particles. . . .
and yes these are newly created ICs.
Edited by Peter W. DraperAdded 1 commit:
- dd823b4f - Make sure we run with gravity or SPH.
Added 1 commit:
- 5c7ae702 - Updated the unit tests for the new read_ic() and parser functions signatures.
Added 1 commit:
- 754bd4be - Tell git to ignore the output of the parser test.
Please register or sign in to reply