Skip to content
Snippets Groups Projects

Cleanup csds

Merged Loic Hausammann requested to merge cleanup_csds into master

The CSDS has grown a lot through the years and became more and more complex. In this merge request, I am simplifying greatly the API in order to cleanup the code.

Modifications:

  • The module .c files are removed
  • A single function is needed for the modules
  • The logfile header is slightly modified and now includes which fields are used for which particles (along with the writing order).

Fixes #752 (closed).

Edited by Matthieu Schaller

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • Loic Hausammann added 2 commits

    added 2 commits

    Compare with previous version

  • Loic Hausammann resolved all threads

    resolved all threads

  • Loic Hausammann marked this merge request as ready

    marked this merge request as ready

  • @matthieu This merge request is ready. A lot of changes were required to update the API. I think now the code is a lot simpler. The file that I sent you on slack is part of the MR. I think the best would be to take a quick look at the file I sent you and, if you wish some changes, I will update the MR before your full review.

    I should stop developing the CSDS for one month, thus feel free to take your time on this merge request.

  • assigned to @matthieu and unassigned @lhausammann

  • added 1 commit

    Compare with previous version

  • Thanks, I will go through it.

    Can you point me towards the header you mention?

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading