More physical definition of SPH kernel functions
This "solves" #97 (closed).
- I have split the SPH and gravity kernels into two separate files for ease of use. That explains a lot of the file changes below.
- Corrected a small typo in the hydro.h files. The mistake was not leading to wrong physics results but would slow down convergence towards the correct h in the ghost task.
- When switching kernel function, the resolution is not modified any more. This was the main point of #97 (closed).
- The documentation of the kernels has increased and I have updated the .tex documents and figures to be completely consistent with the code.
In normal mode (i.e. without editing const.h) the results are identical.
Merge request reports
Activity
Added 1 commit:
- e38e33dc - const for the vectorization win !
Added 1 commit:
- 766363b0 - Corrections to the kernel definition TeX document
Added 52 commits:
-
766363b0...05ac290c - 51 commits from branch
master
- bcb63b9c - Merge branch 'master' into updated_vectorisation_tests
-
766363b0...05ac290c - 51 commits from branch
mentioned in commit 1cb97461
This version doesn't vectorise out of the box for the Wendland C2 kernel. It complains about assumed dependencies in the 2nd loop of DOPAIR1 and won't vectorise loop 1 as it thinks that no speedup would be gained from vectorising. I needed to unroll the loop on line 180 manually and set the address of
kernel_coeffs
on line 173 to 0. The various#define gamma
constants needed to be cast as floats in the#define
statement not in the code directly to prevent data type conversions in the vectorised code.I have submitted a bug report to Intel about the loop unrolling and
kernel_coeffs
addressing issue.