Add message for filesize in csds

As the CSDS over allocate the file size, we need a way to know the actual file size used.

Currently, I am doing a MPI communication in between each step just to print this information. I am not sure what is the best approach:

• Output every N steps
• Doing the MPI communication only if required (but I am not sure how to get the verbosity level on nodes != 0)
• Fine like this as it should not be a significant amount of time
• Adding it to engine_collect_end_step
• Something else?

changed milestone to %Continuous Simulation Data Stream

Add it to the collectgroup mechanism. That is used to reduce information after every step.

added 1 commit

• e0675cb7 - CSDS: move file size into collect group

Compare with previous version

added 1 commit

• c4a44209 - Remove unwanted changes

Compare with previous version

The merge request is ready to be merged.

To test it, I have run the SedovBlast_3D example with/without MPI and with/without CSDS.

marked this merge request as ready

added 1 commit

• e0b689ac - Use 1024 and not 1000

Compare with previous version

resolved all threads

Can you make the call to csds_get_current_filesize_used_gb() outside of the collectgroup? I'd like collectgroup to do no work besides MPI comms.

Also saves you from passing the engine in. Just pass 0 if running without CSDS.

added 1 commit

• 72648e33 - Move print outside collect_end_step + compute csds size outside collectgroup

Compare with previous version

added 1 commit

• d056c321 - Initialize variable in all cases

Compare with previous version

Ok I moved the print outside engine_collect_end_step and the function outside of collectgroup.

> ./configure
...
> make
...
engine_collect_end_of_step.c: In function ‘engine_collect_end_of_step’:
engine_collect_end_of_step.c:503:30: error: implicit declaration of function ‘csds_get_current_filesize_used_gb’ [-Werror=implicit-function-declaration]
  503 |     data.csds_file_size_gb = csds_get_current_filesize_used_gb(e->csds, e);
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[3]: *** [Makefile:2383: libswiftsim_la-engine_collect_end_of_step.lo] Error 1

added 1 commit

• 73424790 - add ifdef

Compare with previous version

I forgot an ifdef. Sorry about that.

approved this merge request

merged

mentioned in commit 5c20f5dc