Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 57
    • Issues 57
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !1353

Draft: Subtask speedup - Still requires work

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Matthieu Schaller requested to merge subtask_speedup into master May 06, 2021
  • Overview 87
  • Commits 87
  • Changes 77

For now, compile with CFLAGS=-DONLY_SUBTASKS added to the configuration line.

This introduces significantly faster neighbour finding in particle distributions with strong density gradients. For instance planetary applications or problematic feedback-disturbed galaxies.

Changes:

  • Add the brute-force density checks to the planetary scheme (not just sphenix)
  • Rewrite the recursion logic in the hydro and stars sub-task:
    • The interaction functions have extra parameters to optionally consider particles only between 0.5 * width and width
    • The subtask recursion now continues to lower level if we reach a level where h is too large. From that level on, we will just use the feature of only considering particles in the appropriate range of h.
    • When recursing, only the h_max of active particles is considered, not all particles.

Notes:

  • We will consider c7adb289 separately.
  • In a second phase, I'll remove entirely the self + pair tasks and keep only the subs.

Todo:

  • Verify RT isn't broken
  • Verify MPI runs are happy.
  • Port changes to the other hydro schemes.
  • Handle particles drifting out of their cells.

Fixes #688 (closed).

Edited Jul 19, 2022 by Matthieu Schaller
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: subtask_speedup