Use only min mass gas in time step
Fix #758 (closed)
My student finished its simulations and everything seems alright. Do you wish to keep the current behavior for your simulations or are you fine if merge it like this?
Merge request reports
Activity
added GEAR SPH performance labels
I used to have a student that was working on it, but I have no idea what he is doing right now. @yvesrevaz Do you know what is going on?
This issue was not a priority for him. So, nothing has been done. I think to move on on this point, the best would be to have a parameter that allow to switch, as suggested by Loic, without breaking anything. Obtaining a power spectrum would be of course ideal, but I have unfortunately no manpower right know to do this test, and at Lastro, we have no simple way to extract the power spectrum from a Swift output. If someone from Swift has a tool fully ready to do it, I will be happy to try.
added 269 commits
-
e93c9d61...068064ac - 267 commits from branch
master
- e00d697e - Use only min mass gas in time step
- f378c456 - Add comment
-
e93c9d61...068064ac - 267 commits from branch
Ok. I have settled for a runtime parameter switching the behaviour from the default to the case where only the minimal gas mass is considered for the mesh RMS time-step condition. The parameter is switched on in the GEAR zoom example. If unspecified, it defaults to
0
, i.e. use the old behaviour.mentioned in commit 8b8250fa