WIP: Rename logger into CSDS
In this merge request, I am renaming the logger into CSDS. I have also removed the logger in modules that were not really supported (e.g. stars/None
but stars/Basic
is still supported).
My main worry about this merge request is the star formation logger. I have been careful to avoid changing it, but it would be nice to have an extra check.
My tests: started with a clean branch; compiled ./configure --with-subgrid=EAGLE --enable-debugging-checks
; compiled ./configure --enable-csds --enable-debugging-checks --with-hydro=gadget2
(crashed as expected due to the missing initialization of the submodule); compiled the checks; compiled ./configure --with-subgrid=GEAR --enable-csds
.
Do you wish another test?
I am still trying to push the update of the csds-reader commit and will remove the WIP once it is done.
Merge request reports
Activity
changed milestone to %Continuous Simulation Data Stream
added cleanup label
Peter will try to update gitlab once he will be back. Therefore @matthieu we can either start the merging process as it is and we manually checkout the csds' master, or we wait his return.
@pdraper one of the worries related to the Gitlab server itself was this PR. Do you think we are now in a safe enough situation to consider this big change?
I am closing this merge request. There is still an issue with this branch. I have copy/paste the diff into another merge request that contains the submodule update !1347 (merged)
mentioned in merge request !1347 (merged)