Logger add periodicity

Implement #726 (closed) @nnrw56 you might be interested.

Here I am doing a few different things in order to add the periodicity:

• Finally starting to implement the yaml file.
• Adding a structure that stores the required parameters
• Adding some checks in src/logger.c
• Fixing a small issue in logger/logger_index.c
• Improving the script tools/read_index_file.py in order to be able to read a bit the logfile.
• Adding a python function that provides the box size.

changed milestone to %Continuous Simulation Data Stream

added i/o label

assigned to @nnrw56 and unassigned @matthieu

Hi Loic!

This MR has changes in 24 files.

24 files.

In the change description, you describe six distinct issues that this MR fixes. Could you please split it up into six MR, one for each issue? It will make it way easier for me, or anybody else, to review.

Cheers, Pedro

I am changing the API, therefore I have to modify a lot of files...

added 1 commit

• 54e5164f - Remove changes to the io

Compare with previous version

mentioned in merge request !1302 (merged)

You are nevertheless mentioning 6 changes. So that is why it's weird to have it as a single unit.

Yes but 4 of them are linked together, one is a one line change and the last one is the python file. If you wish I can move the python file outside of the merge request, but I do not see how it is really making a difference.

added 38 commits

• 54e5164f...0bb2f777 - 32 commits from branch master
• 11a18880 - Implement periodicity
• 8b37c918 - Add missing files
• c93453b4 - Cleanup
• 51b9bca0 - Format
• 840cdd39 - Remove changes to the io
• 8046d70b - Format

Compare with previous version

added 26 commits

• 8046d70b...27cc04d2 - 19 commits from branch master
• 8c254d36 - Implement periodicity
• 6d5e7644 - Add missing files
• d8cf640e - Cleanup
• e766387e - Format
• ad73dcc4 - Remove changes to the io
• 62ae524a - Format
• b7075601 - Use `box_wrap`

Compare with previous version

What is the status of this?

I am currently waiting on your answers to the open discussions.

resolved all threads

merged

mentioned in commit 843cbcdc

mentioned in commit lhausammann/csds-reader@1a0c3f76