Implement particle selection

In this merge request, I am adding the argument part_ids to the function get_particle_data. It allows to request specific particles to the logger.

changed milestone to %Continuous Simulation Data Stream

added enhancement i/o python labels

added 8 commits

• 03a4415e...0b866c55 - 7 commits from branch master
• 4288332b - Implement particle selection

Compare with previous version

added 1 commit

• 234cbcca - Update example

Compare with previous version

added 1 commit

• 38afe127 - Update kwarg and fix id search

Compare with previous version

added 1 commit

• c87b71dc - Cleanup and deal properly with particles removed

Compare with previous version

Okay, a few things here:

1. You may want to implement your gas_type as an enum? Or have it provided as metadata in the log file. Personally, I really dislike the PartType0 convention, but this might be difficult to do in practice.
2. In the case where no particles are found, you should probably raise an exception (as this is probably undesired behaviour). A custom exception is probably a good call here, like ParticlesNotFoundError or something.
3. In the case where some of the particles were not found, I think you just carry on as if nothing has happened. You could add another parameter called strict_search or something where if not all of the particle IDs were found you still raise ParticlesNotFoundError.
4. I'm not sure that having to provide exactly len(particle_types) lists is the best way to structure all of this. Have you considered having a separate reader object, or e.g. reader.X for each particle type? I think that would make the API a lot easier to understand.

Thanks for your comments!

1. I agree with you, I will try to create some enum.
2. It is easy to do, I will implement this.
3. I am not sure to really see the use case. I think that the user can simply check it by himself.
4. I am not really convinced by your idea (but neither by mine), but it is something worth exploring. Any comment about it? @nnrw56 and @matthieu.

added 1 commit

• 9351945a - Update style

Compare with previous version

added 1 commit

• a79cb6c8 - Python return dict not list anymore + format

Compare with previous version

added 1 commit

• 79d98d5f - Update API

Compare with previous version

added 1 commit

• df51ec13 - Add enum

Compare with previous version

added 1 commit

• 7d4fe03d - Cleanup

Compare with previous version

unmarked as a Work In Progress