Logger add modules

Nothing really interesting here, I am fully adding the logger to GEAR (writing not reading). Therefore I have implemented the logger for the chemistry and star formation. I would say that the only interesting file is logger.c.

By the way, in the none/default module, I have a static variable that is not used in the writer, but we need it in the reader. What is it the best way to deal with this compilation error? Currently it is commented, thus I will not be able to compile the reader when I will implement it.

I have also realized that my 2 previous merge requests were not compiling and I am fixing them here (I do not what happened to me this week ^^").

changed milestone to %Continuous Simulation Data Stream

added 1 commit

• b80cca29 - format

Compare with previous version

What static variable are you talking about? And what bugs from previous PRs?

Do the new chemistry and SF function need implementing in the other schemes? Or will it not be a problem if I don't compile with the logger on?

added 58 commits

• b80cca29...61dcee52 - 48 commits from branch master
• 7f4ad6b3 - Fix history locking
• e3f1f7ca - Implement logging of the chemistry
• 21bad4b9 - No need to do feedback
• e83f4523 - Fix feedback
• f023a118 - Implement GEAR
• 6a058ac3 - Logger: Implement star formation
• 6e81f86f - Add missing files
• d1b18804 - Logger: Star formation is compiling
• e4f3f5b3 - format
• b1114df1 - format

Compare with previous version

added 1 commit

• 2718e607 - Remove unwanted include

Compare with previous version

I have done the rebase.

added 1 commit

• 9c10c1cb - Update version number

Compare with previous version

mentioned in merge request !1257 (closed)

added 1 commit

• 4378dc9d - Split logger files in .h and .c

Compare with previous version

resolved all threads

added 1 commit

• db14d73d - Fix compilation issues with GEAR

Compare with previous version

Everything is working as expected now.

added 1 commit

• 7040e034 - Format

Compare with previous version

added 1 commit

• 55fc3436 - Add missing include

Compare with previous version

One day we should sit down and have a proper think about all of this. At the moment having 1000s of lines of code with obvious duplications between different files is really not good.

You mean just for the logger? I will write an issue about that and will try to reduce the number of copy/paste in January.