Fix sink time step

Fix #718 (closed)

@matthieu, you might wish to take a look at it.

Not my cleanest fix, but doing it properly would take too much time (I need to implement some communications for the sink particles). Anyway, it will not really decrease our performance and should not create future problems.

added bug label

Could you explain what the wider issue is and why the fix you suggest is sufficient?

The problem arises when looking if a foreign cell is active for the sink particles. As I am not sending the information of the time steps for the cell, it is initialized at -1 and never set to a correct value. In order to fix it properly, I think I need to implement all the logic for the cell (un)pack.

Can you not set the foreign cell's time information to a valid (but inactive) value?

Yes it is possible, but I think it is dangerous for the future. When I will implement the MPI part, it means that I could miss some active cells.

The other possibility is that I implement the communication, but I will need at least half a day to do it.

closed