Isotropic and other feedback modes

Introduces changes from @chaikin in COLIBRE to the main code:

• Add a ray structure to uniformly sample directions around stars and BHs.
• Add 4 modes of feedback for SNII and AGN respectively: random (as now), isotropic, min distance and min density.
• Add the switch for deterministic / stochastic feedback mode for AGN.
• Rename some of the EAGLE AGN parameters for consistency.
• Update the EAGLE parameter files to use min-distance feedback throughout.

added 1 commit

• 3366e399 - initialise the rays in black_holes_init_bpart()

Compare with previous version

added 110 commits

• 3366e399...a4089653 - 95 commits from branch master
• 2acb0555 - Port the ray feedback tools from COLIBRE over.
• aef1f671 - Add the newly required random functions and numbers
• 990c8d31 - Port over the thermal isotropic feedback from COLIBRE
• 231810c0 - In the EAGLE BH model: multi_phase_bondi --> use_multi_phase_bondi &&...
• c2494852 - Ported over the isotropic & min-dist AGN feedback as well as the stochastic/deterministic switch
• bc117b9c - Add a random AGN feedback model to reproduce the old behaviour of EAGLE where...
• c26ff6b5 - Clarify some comments in the new AGN feedback code
• e15a0a27 - Fix the parameter name for the feedback mode in the AGN model
• 2f48f772 - Post-rebase fixes
• bf9ef900 - Also implement the three feedback options for SNII feedback
• 606ac84e - Use the correct random hashes for the SNII feedback
• ef201cc4 - Implement a minimum-density feedback on top of the isotropic ray mechanism
• 78254273 - Fix sign mistake
• 8ee1cf7c - Undo unwanted changes
• ac1d8af8 - initialise the rays in black_holes_init_bpart()

Compare with previous version

unmarked as a Work In Progress

changed title from WIP: Isotropic feedback to Isotropic and other feedback modes

added EAGLE label

assigned to @matthieu

changed the description

added 2 commits

• b6e620c0 - Update all the EAGLE examples to use the new SNII feedback mode options
• bc6e40a9 - Update the other feedback scheme's function signatures

Compare with previous version

added 2 commits

• bffe4d81 - Better documentation strings
• d7ccf082 - Also update the AGN parameters in the EAGLE_ICs examples

Compare with previous version

added 1 commit

• 691f6707 - And same for the low-z EAGLE boxes where we keep to random injection for legacy reasons

Compare with previous version

added 1 commit

• aee64898 - Document the changes to the EAGLE standard model in the README.

Compare with previous version

added 1 commit

• 57e7d8ed - Update also the main parameter file with the new params

Compare with previous version

@dc-bahe1 I am ready to merge the isotropic feedback code but will wait for a time where it does not break your runs.

The only remaining question on my side is what we want as default especially for the stochastic/detemrministic AGN model.

I should also have said there is absolutely no rush with this.

It does not affect my runs at all, since these are all using my development branch (which already includes these updates anyway). So feel free to merge it whenever you want.

I would say deterministic AGN should be the default, given that we are more likely to use this going forward.

added 26 commits

• 57e7d8ed...e540fd2e - 3 commits from branch master
• b69f71bf - Port the ray feedback tools from COLIBRE over.
• 0569cbb5 - Add the newly required random functions and numbers
• 4d94c517 - Port over the thermal isotropic feedback from COLIBRE
• e4e6e2bd - In the EAGLE BH model: multi_phase_bondi --> use_multi_phase_bondi &&...
• 209d201e - Ported over the isotropic & min-dist AGN feedback as well as the stochastic/deterministic switch
• f3f531a5 - Add a random AGN feedback model to reproduce the old behaviour of EAGLE where...
• 248f2b36 - Clarify some comments in the new AGN feedback code
• af1fbb94 - Fix the parameter name for the feedback mode in the AGN model
• a841692d - Post-rebase fixes
• bc5e2a7e - Also implement the three feedback options for SNII feedback
• 1e7b9ead - Use the correct random hashes for the SNII feedback
• cafb8765 - Implement a minimum-density feedback on top of the isotropic ray mechanism
• 64fc0cb3 - Fix sign mistake
• 6aca4122 - Undo unwanted changes
• 2e7cf05b - initialise the rays in black_holes_init_bpart()
• 4ac3f40e - Update all the EAGLE examples to use the new SNII feedback mode options
• f7388688 - Update the other feedback scheme's function signatures
• da860186 - Better documentation strings
• 473e8243 - Also update the AGN parameters in the EAGLE_ICs examples
• 87ee9987 - And same for the low-z EAGLE boxes where we keep to random injection for legacy reasons
• c3a308b8 - Document the changes to the EAGLE standard model in the README.
• 9dc7e8c4 - Update also the main parameter file with the new params
• 579814b2 - Use deterministic AGN feedback in the default parameter files

Compare with previous version

added 30 commits

• 579814b2...241c44b5 - 7 commits from branch master
• 25052ef1 - Port the ray feedback tools from COLIBRE over.
• 24836818 - Add the newly required random functions and numbers
• f4e81814 - Port over the thermal isotropic feedback from COLIBRE
• 06cd5039 - In the EAGLE BH model: multi_phase_bondi --> use_multi_phase_bondi &&...
• 068ec208 - Ported over the isotropic & min-dist AGN feedback as well as the stochastic/deterministic switch
• 02ed3c26 - Add a random AGN feedback model to reproduce the old behaviour of EAGLE where...
• 3a504368 - Clarify some comments in the new AGN feedback code
• e203fe30 - Fix the parameter name for the feedback mode in the AGN model
• 241512be - Post-rebase fixes
• 4d3ea8a2 - Also implement the three feedback options for SNII feedback
• a289dfae - Use the correct random hashes for the SNII feedback
• 1ec0b471 - Implement a minimum-density feedback on top of the isotropic ray mechanism
• 46c461ab - Fix sign mistake
• 267c53d6 - Undo unwanted changes
• 15d00d4f - initialise the rays in black_holes_init_bpart()
• 26b6b5a0 - Update all the EAGLE examples to use the new SNII feedback mode options
• ead71400 - Update the other feedback scheme's function signatures
• d322fa64 - Better documentation strings
• 42c0c1c1 - Also update the AGN parameters in the EAGLE_ICs examples
• ec389d13 - And same for the low-z EAGLE boxes where we keep to random injection for legacy reasons
• fa58ae97 - Document the changes to the EAGLE standard model in the README.
• 8b8ac42d - Update also the main parameter file with the new params
• 12cf4c25 - Use deterministic AGN feedback in the default parameter files

Compare with previous version

All runs behaved as expected so I'll merge this tomorrow unless any problems get spotted.

@chaikin any thoughts on the port of the ray model to the main code?

I have switched to deterministic AGN feedback for all the relevant parameter files.