Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 57
    • Issues 57
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !1197

Fix final snapshot properties

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Matthieu Schaller requested to merge fix_final_dump into master Oct 16, 2020
  • Overview 11
  • Commits 1
  • Changes 6

The final dump of stats/snapshot/VR should have a drift but not a drift that initialises the particles. This was triggered by the jenkins suite.

@jborrow somehow, we never caught that the final snapshot had wrong values for things that get initialised in the drift and hence zeroed. Like the densities. Is that really true? Now that the default is SPHENIX, the code is actually crashing on the final dump as we try to gather entropies in the stats and this leads to a division by 0. Did we always have garbage densities in the final snapshots (not with an output list) or does that occur only if we use a fixed number of steps (-n)?

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_final_dump