Skip to content
Snippets Groups Projects

Minor Updates to Hydro

Merged Josh Borrow requested to merge f_ij_fix_in_all_schemes into master
All threads resolved!

Minor updates to various hydro schemes:

  • Default, Minimal: Update to use the correct f_ij based on our neighbour definition and to use f_ij consistently. Gadget2 has been left the same as this is a reference implementation.
  • Made SPHENIX the default hydrodynamics scheme if none is specified. This might break some tests?
  • Made the Default be called Phantom, and added documentation for it.

Implements #700 (closed) and #713 (closed).

Edited by Matthieu Schaller

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Matthieu Schaller
  • Matthieu Schaller
  • added 1 commit

    • 35996719 - Fix missing initialisation in testActivePair for the case of PHANTOM

    Compare with previous version

  • All tests are now passing.

  • Planetary hydro is 99% the same as copy-pasted Minimal, does it need these changes too?

  • If you want to be completely formally correct in the cases where you have particles masses that are different then in principle yes. In practice the difference is invisible.

  • Cool, that's fine with me then, just spotted this while looking for something else so thought I'd ask

  • Josh Borrow added 1 commit

    added 1 commit

    • 3704baf5 - Address matthieu's comments on docs

    Compare with previous version

  • Josh Borrow resolved all threads

    resolved all threads

  • Author Developer

    Should have addressed your comments on the documentation

  • mentioned in commit 53f7ccc6

  • Please register or sign in to reply
    Loading