Skip to content
Snippets Groups Projects

Logger python

All threads resolved!
Merged Loic Hausammann requested to merge logger_python into master
All threads resolved!

Here I am updating the API for python and now use python's stack when printing an error.

Edited by Loic Hausammann

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • Loic Hausammann changed target branch from logger_reader to master

    changed target branch from logger_reader to master

  • Loic Hausammann added 80 commits

    added 80 commits

    Compare with previous version

  • Loic Hausammann unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Loic Hausammann assigned to @matthieu and unassigned @nnrw56

    assigned to @matthieu and unassigned @nnrw56

  • Hey, pedro does not have the time to review it. Can you do it Matthieu? Nothing fancy here, just python related stuff.

  • Can you summarize in a paragraph what the changes are? This will help me go through the logic of what is going on. Thanks!

  • Previously the API was a bit too dirty, I am cleaning it in order to slowly get towards the following one https://gitlab.cosma.dur.ac.uk/swift/swiftsim/-/wikis/logger%20reader%20api.

    I have created my own error function (error_python) that prints the python stack if we are compiling with python.

    I am creating a python class for the logger (struct PyObjectReader), it's function __init__ (Reader_init) along with the destructor (Reader_dealloc) and the two required function for the keyword with (__enter__ and __exit__ in python, pyEnter and pyExit in my code C). The list libloggerReaderMethods will give you details (and docstring) about all the methods owned by my new class.

    How familiar are you with python in C? If you wish I can deeply comment the merge request.

  • Matthieu Schaller
  • added 1 commit

    • a26c653d - First correction from review

    Compare with previous version

  • added 1 commit

    • 33d63c79 - Update format + change makefile variable name

    Compare with previous version

  • I have done the required changes.

  • Matthieu Schaller resolved all threads

    resolved all threads

  • mentioned in commit ac2362fb

  • Please register or sign in to reply
    Loading