WIP: Add a small drift before dumping a restart file to avoid problems of coordination (!1080) · Merge requests · SWIFT / SWIFTsim · GitLab

Snippets Groups Projects

Closed Matthieu Schaller requested to merge snapshot_stop_coordination into master 5 years ago

1 unresolved thread

Does what it says on the tin. This prevents a crash (with checks on) or an inconsistency when a snapshot is written during the same step as the code dumps restart files.

Fixes #624 (closed).

Edited 4 years ago by Matthieu Schaller

Activity

Matthieu Schaller @matthieu 5 years ago

Author Owner

@rttw52 could you check whether this fixes the issue you reported of a crash following an unlucky restart - snapshot combination?
Stuart McAlpine @rttw52 5 years ago

Developer

Yes this fixes the issue when an output/restart are produced during the same timestep, and when both are requested on the final timestep.
Matthieu Schaller assigned to @pdraper 5 years ago

assigned to @pdraper
Matthieu Schaller changed the description 5 years ago

changed the description
Matthieu Schaller @matthieu 4 years ago

Author Owner

Great. Let's test this a bit more thoroughly now before merging.

Edited 4 years ago by Matthieu Schaller
Peter W. Draper @pdraper started a thread on the diff 4 years ago

src/engine.c

       restart_remove_previous(e->restart_file);
       /* Drift all particles first (may have just been done). */
       if (!drifted_all) engine_drift_all(e, /*drift_mpole=*/1);
       if (!drifted_all) {

Matthieu Schaller marked as a Work In Progress 4 years ago

marked as a Work In Progress

Matthieu Schaller @matthieu 4 years ago

Author Owner

"WIPed" as there might be a cleaner solution: check for restarts before any physics dumps. We would, however, need to make sure the snapshot is not written a second time if we were to restart from these exact set of check-point files.

Matthieu Schaller closed 4 years ago

closed

Please register or sign in to reply