Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 53
    • Issues 53
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 19
    • Merge requests 19
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !1056

Add Star formation spart struct

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Folkert Nobels requested to merge star_formation_birth_struct into master Apr 08, 2020
  • Overview 3
  • Commits 6
  • Changes 22

I implemented the changes as discussed, this change will add an struct for the star particles specifically for the star formation similar to the chemistry struct, this will make the stars and star formation models more modular and also if we want to change what is stored in the stars related to star formation, than we only need to change the star_formation routine. I updated all the star formation and star schemes:

  • EAGLE stars & star formation
  • GEAR stars & star formation
  • Default stars and none star formation
  • Quick Lymann Alpha star formation.

I tested the code with the EAGLE subgrid on the isolated galaxy with feedback and that seems to run to completion. Also the code compiles when I use different subgrid routines and the default ./configure. I am not able to test if the GEAR model works because I don't have crackle (it compiles). Let me know what you think.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: star_formation_birth_struct