Skip to content
Snippets Groups Projects

Line-of-sight output along the z-axis

Merged Matthieu Schaller requested to merge line_of_sight into master

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Matthieu Schaller marked as a Work In Progress

    marked as a Work In Progress

  • This seems quite inefficient overall with many loops over the particles. We should figure out whether there is a better way of doing things.

  • Also, it does not compile:

    line_of_sight.c: In function 'print_los_info':
    line_of_sight.c:102:64: error: format '%lld' expects argument of type 'long long int', but argument 5 has type 'size_t {aka long unsigned int}' [-Werror=format=]
         printf("[LOS %i] Xpos:%g Ypos:%g particles_in_los_total:%lld\n", i,
                                                                 ~~~^
                                                                 %ld
                Los[i].Xpos, Los[i].Ypos, Los[i].particles_in_los_total);
                                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    line_of_sight.c: In function 'do_line_of_sight':
    line_of_sight.c:210:37: error: variable 'LOS_particles_total' set but not used [-Werror=unused-but-set-variable]
         struct line_of_sight_particles *LOS_particles_total;
                                         ^~~~~~~~~~~~~~~~~~~
  • added 1 commit

    Compare with previous version

  • Matthieu Schaller added 55 commits

    added 55 commits

    Compare with previous version

  • Stuart McAlpine added 3 commits

    added 3 commits

    • ea605875 - fixed gatherv
    • a25ec655 - Time LOS process
    • f6d4994b - Added LOS value to param files. Now only does LOS on designated output times.

    Compare with previous version

  • Matthieu Schaller added 64 commits

    added 64 commits

    Compare with previous version

  • added 1 commit

    • 2fb84905 - Applying HDF5 output for LOS

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Stuart McAlpine added 3 commits

    added 3 commits

    • c3a09358 - Now outputs LOS files to HDF5
    • 2c0bbec1 - added some comments
    • fc525b6b - Updated to use hydro write routines

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading