Add a more generic way of dealing with named columns for subgrid models
Does what it says on the tin.
Merge request reports
Activity
mentioned in commit 9058a801
mentioned in issue #664 (closed)
Please register or sign in to reply
Does what it says on the tin.
I have done it for the chemistry. If you agree with the format I'll also modify the cooling.
Looks good. I will try to integrate this with swiftsimio
before you go forward to see if there are gonna be other issues.
Yes, let me know. No rush.
Is it useful to have the length of it separately? Or can you extract it all at once?
While playing with the i/o, I have also added aliases like Particles_Gas
for PartType0
and added the number of particles of a given type as an attribute of each group.
I like it, this will allow us to get rid of even more metadata from the python library.
However your naming scheme is very inconsistent - why not {ParticleName}Particles
, e.g. GasParticles
? There are no underscores anywhere else in the i/o.
Having ParticlesXXX
allowed to have all them next to each others in hdfview where things are listed alphabetically.
Better suggestions are welcomed though.
At the very least I think that the underscore should be removed.
{ParticleName}Particles
sounds much more consistent with the other naming (e.g. the fields for each particle) but ParticlesGas
is fine too if alphabetical listing is important.
The alphabetical listing was more for people that open files in hdfview and get confused by the high number of groups in there compared to the scarce content of gadget-flavoured files.
Let me know if you are happy with these and I'll propagate the updates to colibre.
merged
mentioned in commit 9058a801
mentioned in issue #664 (closed)