Gear star formation split

Here is my implementation of partial star formation. In GEAR, we wish to have a high resolution for the stars, therefore during the star formation, we transform a small part of a gas particle into a star particle.

Here are the key points for the merge request:

• at the beginning of the simulation, I am computing the average mass of the gas particles and use it as the mass of my future particles.
• We use two different functions for the star formation. Either we create a new spart or if the gas particle does not have enough mass we convert it to a spart.
• For creating a new spart, we need a new gpart (A simple copy / paste of the spart functions is enough).
• The code was crashing due to a small mistake in space.c. The function space_allocate_extra was using the wrong number of gparts.
• The same function was not updating the gpart pointers in the black holes when a new gpart is created.

I have been able to do the IsolatedGalaxy and SmallCosmologicalVolume simulations until the end with the new way of SF and will test it more later with my comparison between SWIFT and GEAR.

added 1 commit

• 233d107d - Update the gitignore and small fixes

Compare with previous version

added 1 commit

• 7afc96b5 - format

Compare with previous version

added 1 commit

• cb6f2e4d - Add missing functions

Compare with previous version

added 1 commit

• cce6423c - Correct number of I/O fields

Compare with previous version

assigned to @matthieu

There are merge conflicts. Could you fix them first?

added 35 commits

• cce6423c...7761e32a - 27 commits from branch master
• 3441f2b1 - GEAR: implement computation of stats on part
• 42901820 - GEAR: implemented particle splitting for SF
• 3733e413 - Partial star formation is working
• 9274dc29 - Update the gitignore and small fixes
• a12fa1d5 - format
• 5e628474 - Add missing functions
• a639f4d2 - Correct number of I/O fields
• 0723bfd8 - Fix rebase

Compare with previous version

Done. Do you need something special to compile QLA? I am getting a lot of errors

Here they do not include the correct file: https://gitlab.cosma.dur.ac.uk/swift/swiftsim/blob/master/src/star_formation_logger.h#L34 and there is more error to it. I guess that the QLA team is still working on it and there is no need to do more than adding the new functions.

--with-subgrid=QLA that's all.

Indeed, looks like the merge skipped the new SF function that was added this week. Sorry about that. I have just pushed an update fixing it.

And for the SF logger, that's OK. We don't want to log anything.

Gitlab still reports merge conflicts btw.

A missing parenthesis increases quickly the number of errors. It should be fine now.

added 10 commits

• 33fa0ec4 - 1 commit from branch master
• 73389bd5 - GEAR: implement computation of stats on part
• 54d2fad5 - GEAR: implemented particle splitting for SF
• f29fd5af - Partial star formation is working
• 73fee4d4 - Update the gitignore and small fixes
• 3fe33618 - format
• a01ed69d - Add missing functions
• eea4956a - Correct number of I/O fields
• f219ea57 - Fix rebase
• 62061e85 - Small fix

Compare with previous version

A missing parenthesis increases quickly the number of errors. It should be fine now.

We have all been there.

added 1 commit

• 1d52551f - Applied code formatting tool

Compare with previous version