Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 53
    • Issues 53
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 19
    • Merge requests 19
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !1035

Gear star formation split

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Loic Hausammann requested to merge gear_sf_split into master Mar 13, 2020
  • Overview 45
  • Commits 17
  • Changes 15

Here is my implementation of partial star formation. In GEAR, we wish to have a high resolution for the stars, therefore during the star formation, we transform a small part of a gas particle into a star particle.

Here are the key points for the merge request:

  • at the beginning of the simulation, I am computing the average mass of the gas particles and use it as the mass of my future particles.
  • We use two different functions for the star formation. Either we create a new spart or if the gas particle does not have enough mass we convert it to a spart.
  • For creating a new spart, we need a new gpart (A simple copy / paste of the spart functions is enough).
  • The code was crashing due to a small mistake in space.c. The function space_allocate_extra was using the wrong number of gparts.
  • The same function was not updating the gpart pointers in the black holes when a new gpart is created.

I have been able to do the IsolatedGalaxy and SmallCosmologicalVolume simulations until the end with the new way of SF and will test it more later with my comparison between SWIFT and GEAR.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gear_sf_split