Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 53
    • Issues 53
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 18
    • Merge requests 18
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Issues
  • #552
Closed
Open
Issue created Mar 05, 2019 by Loic Hausammann@lhausammannContributor

Wrong number of neighbours

Currently, we are assuming that c->h_max is always the largest h but this is not the case. Therefore the optimized version of the iact is missing a few particles (less than one particle over 1000).

We can solve it with two different ways either we ensure to have a meaningful c->h_max or we do not break the for loop when reaching c->h_max (https://gitlab.cosma.dur.ac.uk/swift/swiftsim/blob/master/src/runner_doiact.h#L1004 and the one below)

Edited Mar 07, 2019 by Matthieu Schaller
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking