Add debugging checks to make sure all the active tasks are scheduled and that...

Add debugging checks to make sure all the active tasks are scheduled and that no inactive task is being run.

examples/SedovBlast_3D/sedov.yml

@@ -27,7 +27,7 @@ Statistics:
 SPH:
   resolution_eta:        1.2348   # Target smoothing length in units of the mean inter-particle separation (1.2348 == 48Ngbs with the cubic spline kernel).
   delta_neighbours:      0.1      # The tolerance for the targetted number of neighbours.
-  max_smoothing_length:  0.1       # Maximal smoothing length allowed (in internal units).
+  max_smoothing_length:  0.2       # Maximal smoothing length allowed (in internal units).
   CFL_condition:         0.1      # Courant-Friedrich-Levy condition for time integration.
 
 # Parameters related to the initial conditions

src/const.h

@@ -107,6 +107,6 @@
 //#define COOLING_GRACKLE
 
 /* Are we debugging ? */
-//#define SWIFT_DEBUG_CHECKS
+#define SWIFT_DEBUG_CHECKS
 
 #endif /* SWIFT_CONST_H */

src/runner.c

@@ -760,7 +760,7 @@ static void runner_do_drift(struct cell *c, struct engine *e) {
   struct part *const parts = c->parts;
   struct xpart *const xparts = c->xparts;
   struct gpart *const gparts = c->gparts;
-  
+
   /* Clear the active particle counters. */
   c->updated = 0;
   c->g_updated = 0;
@@ -1325,6 +1325,25 @@ void *runner_main(void *data) {
       struct cell *cj = t->cj;
       t->rid = r->cpuid;
 
+/* Check that we haven't scheduled an inactive task */
+#ifdef SWIFT_DEBUG_CHECKS
+      if (cj == NULL) { /* self */
+        if (ci->ti_end_min > e->ti_current)
+          error(
+              "Task (type='%s/%s') should have been skipped ti_current=%d "
+              "c->ti_end_min=%d",
+              taskID_names[t->type], subtaskID_names[t->subtype], e->ti_current,
+              ci->ti_end_min);
+      } else { /* pair */
+        if (ci->ti_end_min > e->ti_current && cj->ti_end_min > e->ti_current)
+          error(
+              "Task (type='%s/%s') should have been skipped ti_current=%d "
+              "ci->ti_end_min=%d cj->ti_end_min=%d",
+              taskID_names[t->type], subtaskID_names[t->subtype], e->ti_current,
+              ci->ti_end_min, cj->ti_end_min);
+      }
+#endif
+
       /* Different types of tasks... */
       switch (t->type) {
         case task_type_self:

src/scheduler.c

@@ -42,6 +42,7 @@
 #include "atomic.h"
 #include "const.h"
 #include "cycle.h"
+#include "engine.h"
 #include "error.h"
 #include "intrinsics.h"
 #include "kernel_hydro.h"
@@ -1049,6 +1050,48 @@ void scheduler_start(struct scheduler *s, unsigned int mask,
   threadpool_map(s->threadpool, scheduler_rewait_mapper, s->tasks, s->nr_tasks,
                  sizeof(struct task), 1000, s);
 
+/* Check we have not missed an active task */
+#ifdef SWIFT_DEBUG_CHECKS
+
+  const int ti_current = s->space->e->ti_current;
+  for (int k = 0; k < s->nr_tasks; k++) {
+
+    struct task *t = &s->tasks[k];
+    struct cell *ci = t->ci;
+    struct cell *cj = t->cj;
+
+    if (cj == NULL) { /* self */
+
+      if (ci->ti_end_min == ti_current && t->skip && t->type != task_type_sort)
+        error(
+            "Task (type='%s/%s') should not have been skipped ti_current=%d "
+            "c->ti_end_min=%d",
+            taskID_names[t->type], subtaskID_names[t->subtype], ti_current,
+            ci->ti_end_min);
+
+      /* Special treatment for sort tasks */
+      if (ci->ti_end_min == ti_current && t->skip &&
+          t->type == task_type_sort && t->flags == 0)
+        error(
+            "Task (type='%s/%s') should not have been skipped ti_current=%d "
+            "c->ti_end_min=%d t->flags=%d",
+            taskID_names[t->type], subtaskID_names[t->subtype], ti_current,
+            ci->ti_end_min, t->flags);
+
+    } else { /* pair */
+
+      if ((ci->ti_end_min == ti_current || cj->ti_end_min == ti_current) &&
+          t->skip)
+        error(
+            "Task (type='%s/%s') should not have been skipped ti_current=%d "
+            "ci->ti_end_min=%d cj->ti_end_min=%d",
+            taskID_names[t->type], subtaskID_names[t->subtype], ti_current,
+            ci->ti_end_min, cj->ti_end_min);
+    }
+  }
+
+#endif
+
   /* Loop over the tasks and enqueue whoever is ready. */
   threadpool_map(s->threadpool, scheduler_enqueue_mapper, s->tasks_ind,
                  s->nr_tasks, sizeof(int), 1000, s);