Skip to content
Snippets Groups Projects
Commit d99f4daf authored by Peter W. Draper's avatar Peter W. Draper
Browse files

Convert negative weights error in partitioning to warning about tic before toc

A small synchronization error is seen on cosma-e that can be fixed using processory affinity, this stops that being critical.
parent e85ecae0
Branches
Tags
1 merge request!192Convert negative weights error in partitioning to warning about tic before toc
...@@ -458,9 +458,15 @@ static void repart_edge_metis(int partweights, int bothweights, int nodeID, ...@@ -458,9 +458,15 @@ static void repart_edge_metis(int partweights, int bothweights, int nodeID,
t->type != task_type_kick && t->type != task_type_init) t->type != task_type_kick && t->type != task_type_init)
continue; continue;
/* Get the task weight. */ /* Get the task weight. This can be slightly negative on multiple board
* computers when the runners are not pinned to cores, don't stress just
* make a report and ignore these tasks. */
int w = (t->toc - t->tic) * wscale; int w = (t->toc - t->tic) * wscale;
if (w < 0) error("Bad task weight (%d).", w); if (w < 0) {
message("Task toc before tic: -%.3f %s, (try using processor affinity).",
clocks_from_ticks( t->tic - t->toc ), clocks_getunit());
w = 0;
}
/* Do we need to re-scale? */ /* Do we need to re-scale? */
wtot += w; wtot += w;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment