Merge branch 'scheduler_doforcesplit_off' into 'master'

Scheduler doforcesplit off

The scheduler_doforcesplit flag will make the scheduler split tasks that have too many particles even if the smoothing lengths inside the cells are too large. This means that interactions will be generated with cells outside of the 27 direct neighbours.

Switching this off for now as it causes massive problems with engine_addlinks, which assumes a maximum number of density/force tasks per cell. I have added a comment warning users to this effect, should re-design engine_addlinks at some point to avoid this type of problem.

Note that I don't want to remove this option permanently as it could be useful in cases with density gradients >2.

See merge request !3


Former-commit-id: 7dbeba7b1af4f75e17648935ac5409c0a2e617ab

src/scheduler.h

@@ -24,7 +24,9 @@
 #define scheduler_dosub                      1
 #define scheduler_maxsteal                   10
 #define scheduler_maxtries                   2
-#define scheduler_doforcesplit               1
+#define scheduler_doforcesplit               0 /* Beware: switching this on can/will
+                                                  break engine_addlink as it assumes
+                                                  a maximum number of tasks per cell. */
 
 /* Flags . */
 #define scheduler_flag_none                  0