Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
SWIFTsim
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Deploy
Releases
Model registry
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
SWIFT
SWIFTsim
Commits
7e81e634
Commit
7e81e634
authored
6 years ago
by
Peter W. Draper
Browse files
Options
Downloads
Patches
Plain Diff
Add summary of active memory at dump time.
parent
cd748405
No related branches found
No related tags found
1 merge request
!838
Speed up memory use reports
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/memuse.c
+72
-2
72 additions, 2 deletions
src/memuse.c
with
72 additions
and
2 deletions
src/memuse.c
+
72
−
2
View file @
7e81e634
...
@@ -48,7 +48,7 @@ extern int engine_rank;
...
@@ -48,7 +48,7 @@ extern int engine_rank;
extern
int
engine_current_step
;
extern
int
engine_current_step
;
/* Entry for logger of memory allocations and deallocations in a step. */
/* Entry for logger of memory allocations and deallocations in a step. */
#define MEMUSE_MAXLAB
64
#define MEMUSE_MAXLAB
32
struct
memuse_log_entry
{
struct
memuse_log_entry
{
/* Rank in action. */
/* Rank in action. */
...
@@ -74,6 +74,11 @@ struct memuse_log_entry {
...
@@ -74,6 +74,11 @@ struct memuse_log_entry {
/* Key for hashmap. Formatted address of memory. */
/* Key for hashmap. Formatted address of memory. */
char
key
[
MEMUSE_MAXLAB
+
1
];
char
key
[
MEMUSE_MAXLAB
+
1
];
/* Sum of memory associated with this label. Only used when summing active
* memory and the only for the first entry with this label. */
size_t
active_sum
;
size_t
active_count
;
};
};
/* The log of allocations and frees. */
/* The log of allocations and frees. */
...
@@ -125,6 +130,7 @@ static void memuse_log_reallocate(size_t ind) {
...
@@ -125,6 +130,7 @@ static void memuse_log_reallocate(size_t ind) {
}
}
}
}
/**
/**
* @brief Log an allocation or deallocation of memory.
* @brief Log an allocation or deallocation of memory.
*
*
...
@@ -157,6 +163,51 @@ void memuse_log_allocation(const char *label, void *ptr, int allocated,
...
@@ -157,6 +163,51 @@ void memuse_log_allocation(const char *label, void *ptr, int allocated,
atomic_inc
(
&
memuse_log_done
);
atomic_inc
(
&
memuse_log_done
);
}
}
/**
* @brief Gather the labels of the current active memory and sum the memory
* associated with them. Called from hashmap_iterate().
*/
static
int
memuse_active_dump_gather
(
any_t
item
,
any_t
data
)
{
/* Get label hashmap and the active log entry. */
map_t
active_hashmap
=
(
map_t
)
item
;
struct
memuse_log_entry
*
stored_log
=
(
struct
memuse_log_entry
*
)
data
;
/* Look for this label. */
struct
memuse_log_entry
*
active_log
=
NULL
;
int
error
=
hashmap_get
(
active_hashmap
,
stored_log
->
label
,
(
void
**
)(
&
active_log
));
if
(
error
!=
MAP_OK
)
{
/* Not seen yet, so add an entry. */
hashmap_put
(
active_hashmap
,
stored_log
->
label
,
stored_log
);
stored_log
->
active_sum
=
0
;
stored_log
->
active_count
=
0
;
}
/* And increment sum. */
stored_log
->
active_sum
+=
stored_log
->
size
;
stored_log
->
active_count
++
;
return
MAP_OK
;
}
/**
* @brief Output the active memory usage.
*/
static
int
memuse_active_dump_output
(
any_t
item
,
any_t
data
)
{
/* Get label hashmap and the active record. */
FILE
*
fd
=
(
FILE
*
)
item
;
struct
memuse_log_entry
*
stored_log
=
(
struct
memuse_log_entry
*
)
data
;
/* Output. */
fprintf
(
fd
,
"## %s %zd %zd
\n
"
,
stored_log
->
label
,
stored_log
->
active_sum
,
stored_log
->
active_count
);
return
MAP_OK
;
}
/**
/**
* @brief dump the log to a file and reset, if anything to dump.
* @brief dump the log to a file and reset, if anything to dump.
*
*
...
@@ -164,6 +215,8 @@ void memuse_log_allocation(const char *label, void *ptr, int allocated,
...
@@ -164,6 +215,8 @@ void memuse_log_allocation(const char *label, void *ptr, int allocated,
*/
*/
void
memuse_log_dump
(
const
char
*
filename
)
{
void
memuse_log_dump
(
const
char
*
filename
)
{
int
error
;
/* Skip if nothing allocated this step. */
/* Skip if nothing allocated this step. */
if
(
memuse_log_count
==
0
)
return
;
if
(
memuse_log_count
==
0
)
return
;
...
@@ -177,13 +230,14 @@ void memuse_log_dump(const char *filename) {
...
@@ -177,13 +230,14 @@ void memuse_log_dump(const char *filename) {
fprintf
(
fd
,
"# cpufreq: %lld
\n
"
,
clocks_get_cpufreq
());
fprintf
(
fd
,
"# cpufreq: %lld
\n
"
,
clocks_get_cpufreq
());
fprintf
(
fd
,
"# dtic rank step label size sum
\n
"
);
fprintf
(
fd
,
"# dtic rank step label size sum
\n
"
);
size_t
maxmem
=
memuse_sum
;
for
(
size_t
k
=
0
;
k
<
memuse_log_count
;
k
++
)
{
for
(
size_t
k
=
0
;
k
<
memuse_log_count
;
k
++
)
{
/* Check if this address has already been used. */
/* Check if this address has already been used. */
struct
memuse_log_entry
*
stored_log
;
struct
memuse_log_entry
*
stored_log
;
sprintf
(
memuse_log
[
k
].
key
,
"%p"
,
memuse_log
[
k
].
ptr
);
sprintf
(
memuse_log
[
k
].
key
,
"%p"
,
memuse_log
[
k
].
ptr
);
int
error
=
hashmap_get
(
memuse_hashmap
,
memuse_log
[
k
].
key
,
error
=
hashmap_get
(
memuse_hashmap
,
memuse_log
[
k
].
key
,
(
void
**
)(
&
stored_log
));
(
void
**
)(
&
stored_log
));
if
(
error
==
MAP_OK
)
{
if
(
error
==
MAP_OK
)
{
...
@@ -220,7 +274,9 @@ void memuse_log_dump(const char *filename) {
...
@@ -220,7 +274,9 @@ void memuse_log_dump(const char *filename) {
continue
;
continue
;
}
}
/* Keep maximum and rolling sum. */
memuse_sum
+=
memuse_log
[
k
].
size
;
memuse_sum
+=
memuse_log
[
k
].
size
;
if
(
memuse_sum
>
maxmem
)
maxmem
=
memuse_sum
;
/* And output. */
/* And output. */
fprintf
(
fd
,
"%lld %d %d %s %zd %zd
\n
"
,
memuse_log
[
k
].
dtic
,
fprintf
(
fd
,
"%lld %d %d %s %zd %zd
\n
"
,
memuse_log
[
k
].
dtic
,
...
@@ -228,6 +284,20 @@ void memuse_log_dump(const char *filename) {
...
@@ -228,6 +284,20 @@ void memuse_log_dump(const char *filename) {
memuse_log
[
k
].
size
,
memuse_sum
);
memuse_log
[
k
].
size
,
memuse_sum
);
}
}
/* The hashmap should only contain active memory, make a report about
* that. */
map_t
active_hashmap
=
hashmap_new
();
/* First we so the sums against the active labels. */
error
=
hashmap_iterate
(
memuse_hashmap
,
memuse_active_dump_gather
,
active_hashmap
);
/* Then make the report. */
error
=
hashmap_iterate
(
active_hashmap
,
memuse_active_dump_output
,
fd
);
hashmap_free
(
active_hashmap
);
/* Clear the log. OK as records are dumped, but note active memory is still
/* Clear the log. OK as records are dumped, but note active memory is still
* in the hashmap. */
* in the hashmap. */
memuse_log_count
=
0
;
memuse_log_count
=
0
;
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment