Do not switch to a steeper slope for the PressureLaw star formation at high...

Do not switch to a steeper slope for the PressureLaw star formation at high densities. Use a minimal BH time-step length of 10^5 yrs.

examples/EAGLE_ICs/EAGLE_100/eagle_100.yml

@@ -143,7 +143,7 @@ EAGLEStarFormation:
   KS_normalisation:                  1.515e-4     # The normalization of the Kennicutt-Schmidt law in Msun / kpc^2 / yr.
   KS_exponent:                       1.4          # The exponent of the Kennicutt-Schmidt law.
   min_over_density:                  100.0        # The over-density above which star-formation is allowed.
-  KS_high_density_threshold_H_p_cm3: 1e3          # Hydrogen number density above which the Kennicut-Schmidt law changes slope in Hydrogen atoms per cm^3.
+  KS_high_density_threshold_H_p_cm3: 1e8          # Hydrogen number density above which the Kennicut-Schmidt law changes slope in Hydrogen atoms per cm^3.
   KS_high_density_exponent:          2.0          # Slope of the Kennicut-Schmidt law above the high-density threshold.
   EOS_entropy_margin_dex:            0.3          # When using Z-based SF threshold, logarithm base 10 of the maximal entropy above the EOS at which stars can form.
   threshold_norm_H_p_cm3:            0.1          # When using Z-based SF threshold, normalisation of the metal-dependant density threshold for star formation in Hydrogen atoms per cm^3.
@@ -249,3 +249,4 @@ EAGLEAGN:
   threshold_minor_merger:             0.1             # Mass ratio threshold to consider a BH merger as 'minor'
   merger_threshold_type:              2               # Type of velocity threshold for BH mergers (0: v_circ at kernel edge, 1: v_esc at actual distance, with softening, 2: v_esc at actual distance, no softening).
   merger_max_distance_ratio:          3.0             # Maximal distance over which two BHs can merge, in units of the softening length.
+  minimum_timestep_Myr:               0.1             # Minimum of the accretion-limited time-step length.

examples/EAGLE_ICs/EAGLE_12/eagle_12.yml

@@ -142,7 +142,7 @@ EAGLEStarFormation:
   KS_normalisation:                  1.515e-4     # The normalization of the Kennicutt-Schmidt law in Msun / kpc^2 / yr.
   KS_exponent:                       1.4          # The exponent of the Kennicutt-Schmidt law.
   min_over_density:                  100.0        # The over-density above which star-formation is allowed.
-  KS_high_density_threshold_H_p_cm3: 1e3          # Hydrogen number density above which the Kennicut-Schmidt law changes slope in Hydrogen atoms per cm^3.
+  KS_high_density_threshold_H_p_cm3: 1e8          # Hydrogen number density above which the Kennicut-Schmidt law changes slope in Hydrogen atoms per cm^3.
   KS_high_density_exponent:          2.0          # Slope of the Kennicut-Schmidt law above the high-density threshold.
   EOS_entropy_margin_dex:            0.3          # When using Z-based SF threshold, logarithm base 10 of the maximal entropy above the EOS at which stars can form.
   threshold_norm_H_p_cm3:            0.1          # When using Z-based SF threshold, normalisation of the metal-dependant density threshold for star formation in Hydrogen atoms per cm^3.
@@ -248,3 +248,4 @@ EAGLEAGN:
   threshold_minor_merger:             0.1             # Mass ratio threshold to consider a BH merger as 'minor'
   merger_threshold_type:              2               # Type of velocity threshold for BH mergers (0: v_circ at kernel edge, 1: v_esc at actual distance, with softening, 2: v_esc at actual distance, no softening).
   merger_max_distance_ratio:          3.0             # Maximal distance over which two BHs can merge, in units of the softening length.
+  minimum_timestep_Myr:               0.1             # Minimum of the accretion-limited time-step length.

examples/EAGLE_ICs/EAGLE_25/eagle_25.yml

@@ -142,7 +142,7 @@ EAGLEStarFormation:
   KS_normalisation:                  1.515e-4     # The normalization of the Kennicutt-Schmidt law in Msun / kpc^2 / yr.
   KS_exponent:                       1.4          # The exponent of the Kennicutt-Schmidt law.
   min_over_density:                  100.0        # The over-density above which star-formation is allowed.
-  KS_high_density_threshold_H_p_cm3: 1e3          # Hydrogen number density above which the Kennicut-Schmidt law changes slope in Hydrogen atoms per cm^3.
+  KS_high_density_threshold_H_p_cm3: 1e8          # Hydrogen number density above which the Kennicut-Schmidt law changes slope in Hydrogen atoms per cm^3.
   KS_high_density_exponent:          2.0          # Slope of the Kennicut-Schmidt law above the high-density threshold.
   EOS_entropy_margin_dex:            0.3          # When using Z-based SF threshold, logarithm base 10 of the maximal entropy above the EOS at which stars can form.
   threshold_norm_H_p_cm3:            0.1          # When using Z-based SF threshold, normalisation of the metal-dependant density threshold for star formation in Hydrogen atoms per cm^3.
@@ -248,3 +248,4 @@ EAGLEAGN:
   threshold_minor_merger:             0.1             # Mass ratio threshold to consider a BH merger as 'minor'
   merger_threshold_type:              2               # Type of velocity threshold for BH mergers (0: v_circ at kernel edge, 1: v_esc at actual distance, with softening, 2: v_esc at actual distance, no softening).
   merger_max_distance_ratio:          3.0             # Maximal distance over which two BHs can merge, in units of the softening length.
+  minimum_timestep_Myr:               0.1             # Minimum of the accretion-limited time-step length.

examples/EAGLE_ICs/EAGLE_25_low_res/eagle_25.yml

@@ -139,7 +139,7 @@ EAGLEStarFormation:
   KS_normalisation:                  1.515e-4     # The normalization of the Kennicutt-Schmidt law in Msun / kpc^2 / yr.
   KS_exponent:                       1.4          # The exponent of the Kennicutt-Schmidt law.
   min_over_density:                  100.0        # The over-density above which star-formation is allowed.
-  KS_high_density_threshold_H_p_cm3: 1e3          # Hydrogen number density above which the Kennicut-Schmidt law changes slope in Hydrogen atoms per cm^3.
+  KS_high_density_threshold_H_p_cm3: 1e8          # Hydrogen number density above which the Kennicut-Schmidt law changes slope in Hydrogen atoms per cm^3.
   KS_high_density_exponent:          2.0          # Slope of the Kennicut-Schmidt law above the high-density threshold.
   EOS_entropy_margin_dex:            0.3          # When using Z-based SF threshold, logarithm base 10 of the maximal entropy above the EOS at which stars can form.
   threshold_norm_H_p_cm3:            0.1          # When using Z-based SF threshold, normalisation of the metal-dependant density threshold for star formation in Hydrogen atoms per cm^3.
@@ -173,6 +173,7 @@ EAGLEFeedback:
   IMF_max_mass_Msun:                  100.0             # Maximal stellar mass considered for the Chabrier IMF in solar masses.
   SNII_min_mass_Msun:                   8.0             # Minimal mass considered for SNII stars in solar masses.
   SNII_max_mass_Msun:                 100.0             # Maximal mass considered for SNII stars in solar masses.
+  SNII_feedback_model:                  MinimumDistance # Feedback modes: Random, Isotropic, MinimumDistance, MinimumDensity
   SNII_sampled_delay:                   1               # Sample the SNII lifetimes to do feedback.
   SNII_delta_T_K:                       3.16228e7       # Change in temperature to apply to the gas particle in a SNII thermal feedback event in Kelvin.
   SNII_energy_erg:                      1.0e51          # Energy of one SNII explosion in ergs.
@@ -205,8 +206,8 @@ EAGLEFeedback:
 # EAGLE AGN model
 EAGLEAGN:
   subgrid_seed_mass_Msun:             1.0e4           # Black hole subgrid mass at creation time in solar masses.
-  multi_phase_bondi:                  0          # Compute Bondi rates per neighbour particle?
-  subgrid_bondi:                      0          # Compute Bondi rates using the subgrid extrapolation of the gas properties around the BH?
+  use_multi_phase_bondi:              0               # Compute Bondi rates per neighbour particle?
+  use_subgrid_bondi:                  0               # Compute Bondi rates using the subgrid extrapolation of the gas properties around the BH?
   with_angmom_limiter:                0               # Are we applying the Rosas-Guevara et al. (2015) viscous time-scale reduction term?
   viscous_alpha:                      1e6             # Normalisation constant of the viscous time-scale in the accretion reduction term
   with_boost_factor:                  0               # Are we using the model from Booth & Schaye (2009)?
@@ -219,6 +220,8 @@ EAGLEAGN:
   max_eddington_fraction:             1.              # Maximal allowed accretion rate in units of the Eddington rate.
   eddington_fraction_for_recording:   0.1             # Record the last time BHs reached an Eddington ratio above this threshold.
   coupling_efficiency:                0.1             # Fraction of the radiated energy that couples to the gas in feedback events.
+  AGN_feedback_model:                 MinimumDistance # Feedback modes: Random, Isotropic, MinimumDistance, MinimumDensity
+  AGN_use_deterministic_feedback:     1               # Deterministic (reservoir) [1] or stochastic [0] AGN feedback?
   use_variable_delta_T:               1               # Switch to enable adaptive calculation of AGN dT [1], rather than using a constant value [0].
   AGN_with_locally_adaptive_delta_T:  1               # Switch to enable additional dependence of AGN dT on local gas density and temperature (only used if use_variable_delta_T is 1).
   AGN_delta_T_mass_norm:              3e8             # Normalisation temperature of AGN dT scaling with BH subgrid mass [K] (only used if use_variable_delta_T is 1).
@@ -242,3 +245,4 @@ EAGLEAGN:
   threshold_minor_merger:             0.1             # Mass ratio threshold to consider a BH merger as 'minor'
   merger_threshold_type:              2               # Type of velocity threshold for BH mergers (0: v_circ at kernel edge, 1: v_esc at actual distance, with softening, 2: v_esc at actual distance, no softening).
   merger_max_distance_ratio:          3.0             # Maximal distance over which two BHs can merge, in units of the softening length.
+  minimum_timestep_Myr:               0.1             # Minimum of the accretion-limited time-step length.

examples/EAGLE_ICs/EAGLE_50/eagle_50.yml

@@ -140,7 +140,7 @@ EAGLEStarFormation:
   KS_normalisation:                  1.515e-4     # The normalization of the Kennicutt-Schmidt law in Msun / kpc^2 / yr.
   KS_exponent:                       1.4          # The exponent of the Kennicutt-Schmidt law.
   min_over_density:                  100.0        # The over-density above which star-formation is allowed.
-  KS_high_density_threshold_H_p_cm3: 1e3          # Hydrogen number density above which the Kennicut-Schmidt law changes slope in Hydrogen atoms per cm^3.
+  KS_high_density_threshold_H_p_cm3: 1e8          # Hydrogen number density above which the Kennicut-Schmidt law changes slope in Hydrogen atoms per cm^3.
   KS_high_density_exponent:          2.0          # Slope of the Kennicut-Schmidt law above the high-density threshold.
   EOS_entropy_margin_dex:            0.3          # When using Z-based SF threshold, logarithm base 10 of the maximal entropy above the EOS at which stars can form.
   threshold_norm_H_p_cm3:            0.1          # When using Z-based SF threshold, normalisation of the metal-dependant density threshold for star formation in Hydrogen atoms per cm^3.
@@ -246,3 +246,4 @@ EAGLEAGN:
   threshold_minor_merger:             0.1             # Mass ratio threshold to consider a BH merger as 'minor'
   merger_threshold_type:              2               # Type of velocity threshold for BH mergers (0: v_circ at kernel edge, 1: v_esc at actual distance, with softening, 2: v_esc at actual distance, no softening).
   merger_max_distance_ratio:          3.0             # Maximal distance over which two BHs can merge, in units of the softening length.
+  minimum_timestep_Myr:               0.1             # Minimum of the accretion-limited time-step length.

examples/EAGLE_ICs/EAGLE_50_low_res/eagle_50.yml

@@ -139,7 +139,7 @@ EAGLEStarFormation:
   KS_normalisation:                  1.515e-4     # The normalization of the Kennicutt-Schmidt law in Msun / kpc^2 / yr.
   KS_exponent:                       1.4          # The exponent of the Kennicutt-Schmidt law.
   min_over_density:                  100.0        # The over-density above which star-formation is allowed.
-  KS_high_density_threshold_H_p_cm3: 1e3          # Hydrogen number density above which the Kennicut-Schmidt law changes slope in Hydrogen atoms per cm^3.
+  KS_high_density_threshold_H_p_cm3: 1e8          # Hydrogen number density above which the Kennicut-Schmidt law changes slope in Hydrogen atoms per cm^3.
   KS_high_density_exponent:          2.0          # Slope of the Kennicut-Schmidt law above the high-density threshold.
   EOS_entropy_margin_dex:            0.3          # When using Z-based SF threshold, logarithm base 10 of the maximal entropy above the EOS at which stars can form.
   threshold_norm_H_p_cm3:            0.1          # When using Z-based SF threshold, normalisation of the metal-dependant density threshold for star formation in Hydrogen atoms per cm^3.
@@ -216,7 +216,7 @@ EAGLEAGN:
   boost_n_h_star_H_p_cm3:             0.1             # Normalization of the power law for the Booth & Schaye 2009 model in cgs (cm^-3).
   radiative_efficiency:               0.1             # Fraction of the accreted mass that gets radiated.
   use_nibbling:                       1               # Continuously transfer small amounts of mass from all gas neighbours to a black hole [1] or stochastically swallow whole gas particles [0]?
-  min_gas_mass_for_nibbling:          9e5             # Minimum mass for a gas particle to be nibbled from [M_Sun]. Only used if use_nibbling is 1.
+  min_gas_mass_for_nibbling:          7.2e6           # Minimum mass for a gas particle to be nibbled from [M_Sun]. Only used if use_nibbling is 1.
   max_eddington_fraction:             1.              # Maximal allowed accretion rate in units of the Eddington rate.
   eddington_fraction_for_recording:   0.1             # Record the last time BHs reached an Eddington ratio above this threshold.
   coupling_efficiency:                0.1             # Fraction of the radiated energy that couples to the gas in feedback events.
@@ -245,3 +245,4 @@ EAGLEAGN:
   threshold_minor_merger:             0.1             # Mass ratio threshold to consider a BH merger as 'minor'
   merger_threshold_type:              2               # Type of velocity threshold for BH mergers (0: v_circ at kernel edge, 1: v_esc at actual distance, with softening, 2: v_esc at actual distance, no softening).
   merger_max_distance_ratio:          3.0             # Maximal distance over which two BHs can merge, in units of the softening length.
+  minimum_timestep_Myr:               0.1             # Minimum of the accretion-limited time-step length.

examples/EAGLE_ICs/EAGLE_6/eagle_6.yml

@@ -142,7 +142,7 @@ EAGLEStarFormation:
   KS_normalisation:                  1.515e-4     # The normalization of the Kennicutt-Schmidt law in Msun / kpc^2 / yr.
   KS_exponent:                       1.4          # The exponent of the Kennicutt-Schmidt law.
   min_over_density:                  100.0        # The over-density above which star-formation is allowed.
-  KS_high_density_threshold_H_p_cm3: 1e3          # Hydrogen number density above which the Kennicut-Schmidt law changes slope in Hydrogen atoms per cm^3.
+  KS_high_density_threshold_H_p_cm3: 1e8          # Hydrogen number density above which the Kennicut-Schmidt law changes slope in Hydrogen atoms per cm^3.
   KS_high_density_exponent:          2.0          # Slope of the Kennicut-Schmidt law above the high-density threshold.
   EOS_entropy_margin_dex:            0.3          # When using Z-based SF threshold, logarithm base 10 of the maximal entropy above the EOS at which stars can form.
   threshold_norm_H_p_cm3:            0.1          # When using Z-based SF threshold, normalisation of the metal-dependant density threshold for star formation in Hydrogen atoms per cm^3.
@@ -248,3 +248,4 @@ EAGLEAGN:
   threshold_minor_merger:             0.1             # Mass ratio threshold to consider a BH merger as 'minor'
   merger_threshold_type:              2               # Type of velocity threshold for BH mergers (0: v_circ at kernel edge, 1: v_esc at actual distance, with softening, 2: v_esc at actual distance, no softening).
   merger_max_distance_ratio:          3.0             # Maximal distance over which two BHs can merge, in units of the softening length.
+  minimum_timestep_Myr:               0.1             # Minimum of the accretion-limited time-step length.

examples/EAGLE_ICs/README

@@ -45,6 +45,10 @@ the following changes have been made (at standard resolution):
    at least 100 (was 57.7).
  - Particles with a density above 10^5 cm^-3 are not turned into
    stars instantaneously any more.
+ - The normalisation of the SF law at high densities has been corrected
+   from the original code where the break in slope of the K-S law
+   also led to a jump. This change of slope is not used anymore (was
+   a K-S slope of 2 at volume particle densities > 10^3 cm^-3).
  - The minimal mass of SNII stars has been raised to 8 Msun (from 6).
  - The SNII feedback heats the particle closest to the star particle
    (was a random set of particles in the kernel).
@@ -78,6 +82,8 @@ the following changes have been made (at standard resolution):
  - The angular momentum term in the BH accretion model of
    Rosas-Guevara et al. (2015) is now switched off.
  - The coupling efficency of the BH feedback is now 0.1 (was 0.15).
+ - The BHs compute a time-step length based on their accretion rate
+   with a minimum time-step length of 10^5 years.
  - The AGN feedback heats the particles closest to the BH particle
    (was a random set of particles in the kernel).
  - The AGN does not use a combination of probability and reservoir