Minor updates to the ANARCHYDU scheme (!961) · Merge requests · SWIFT / SWIFTsim · GitLab

Snippets Groups Projects

Merged Josh Borrow requested to merge anarchy-du-updates into master 5 years ago

1 unresolved thread

Changes to the way that the diffusion limiter is applied.

Activity

Matthieu Schaller @matthieu started a thread on the diff 5 years ago

src/hydro/AnarchyDU/hydro_parameters.h

  * very small in schemes where little diffusion is needed, 0.2-1.0 in
  * schemes (e.g. density-energy) where diffusion is needed to solve
  * the contact discontinuity problem. */
 #define hydro_props_default_diffusion_beta 0.25f
 #define hydro_props_default_diffusion_beta 1.0f

Matthieu Schaller @matthieu 5 years ago

Owner

Does that change also need to be applied to the other anarchy flavours?

Josh Borrow @jborrow 5 years ago

Author Developer

No, I want to leave ANARCHY-PU as the Dalla Vecchia implementation, with ANARCHY-DU being a completely new scheme. Perhaps worth changing the name at some point to make this clear, but that's going to be a pain.

Matthieu Schaller merged 5 years ago

merged

Matthieu Schaller mentioned in commit 5 years ago

mentioned in commit 2541a8f6

Please register or sign in to reply