Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 57
    • Issues 57
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !933

Add Dehnen & Aly E0 density correction

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Josh Borrow requested to merge add_dehnen_aly_density_correction into master Sep 26, 2019
  • Overview 11
  • Commits 8
  • Changes 22

This MR adds the density correction for the Wendland-CX kernels in 3D, as specified in Dehnen & Aly Equation 19. It required:

  • Adding new variables for every kernel in kernel_hydro.h
  • Adding a new parameter file parameter SPH:use_epsilon_density_correction
  • Changing the function signature of hydro_end_density to include a new parameter (a single float passed by value)
  • Updating the relevant sections of the tests and runner
  • Adding the relevant documentation.

It seems to make very little difference to the dynamics; here's the SodShock_3D with and without:

With correction SodShock

Without correction sodshock_no_correction

but I see no reason not to use it in those cases. Either way, I've set it to default to 'off'. I am currently running more tests to see where (if ever) it makes a difference.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: add_dehnen_aly_density_correction