Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 57
    • Issues 57
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !765

Variable AV fix | Cosmology

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Josh Borrow requested to merge viscosity_fix_cosmology into master Mar 20, 2019
  • Overview 52
  • Commits 58
  • Changes 33

Fixes the AV and AD coefficients in ANARCHY and in the Morris & Monaghan AV. Thanks to @bvandenbroucke for the Cosmological Sod Shock tests, they were instrumental in debugging this.

Before fix; artificial diffusion coefficient as a function of space: compare_alpha_broken

After fix: compare_alpha_fixed

I am currently testing this fix with the EAGLE_12 to see if it rectifies the problem we were having there. Once that is over (I guess whether it passes or not), I'll re-assign this and remove the WIP.

Edited Mar 29, 2019 by Josh Borrow
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: viscosity_fix_cosmology