Debug fixes for neighbour finding

Debug fixes for problems with neighbour-finding, no neighbours, and maximum smoothing lengths that came up in planetary test simulations.

Awaiting thorough tests before merging.

unmarked as a Work In Progress

added 2 commits

• fc43e385 - Do not set the signal velocity to 1 in hydro_has_no_neighbours(). Code formatting.
• f0329b64 - Apply the same bug fix to the other hydro schemes.

Compare with previous version

@jborrow as our P-U SPH maintainer, could you check that you agree with the fixes to the P-U scheme?

resolved all discussions

Any chance you could run your suite of hydro-tests to make sure we did not mess up something fundamental?

@matthieu I will set that running this afternoon, should have results by tomorrow.

Thanks!

Looks fine from the hydro test perspective.

Great, thanks!

All tests passed. Thanks for reporting and proposing a fix.

merged

mentioned in commit 507276d6

Thanks, glad it worked!