Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 57
    • Issues 57
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !370

Add checks for particles that are at same position and updates to the h_max of top-level cells.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Peter W. Draper requested to merge ic-checks into master Jul 17, 2017
  • Overview 8
  • Commits 4
  • Changes 1

Investigating #324 (closed) has turned up a couple of issues that we probably should handle better. The first is particles with the same position. These are not allowed. The second is a mismatch between the cells h_max values and those of the particles when running the ghost tasks for the first time and when the initial estimates of h are small, so we get too many top-level cells initially and a regrid is needed (if this isn't done then the particles test to be moved outside their cell and we need to rebuild, even though a rebuild has just been done).

This fixes both by reporting an error when particles are found in the same location, and updates the top-level cells h_max to those of the particles (note this must be followed by a regrid as any sub-cells will have the wrong h_max).

Also now reports if gparts are at the same location. That is inefficient not a show stopper.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: ic-checks