Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 57
    • Issues 57
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !310

Star particles and gparts links over MPI

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Matthieu Schaller requested to merge star_particles into master Feb 02, 2017
  • Overview 19
  • Commits 77
  • Changes 48

A big bundle of changes:

  • Introduce star particles. At the moment they are empty shells but they are ready to be used.
  • An spart is always linked to a gpart and will receive its gravitational forces from there.
  • A gpart now contains an enum containing information about whether it is linked to a part, to an spart or to nothing.
  • Added a more comprehensive test to check that the part<->gpart and spart<->gpart links are correct after every rebuild or MPI transaction.
  • spart get kicked and drifted and get their time-step computed.
  • spart are read-in and written to snapshots (only if running with -S for now).
  • Only the particle types that will be used are now read from ICs. Speeds-up the starting up process.
  • Corrects many incorrect communication of gpart over MPI.

With this in we can run the EAGLE_25 over MPI with gpart and spart activated (e.g. swift_mpi -s -g -S -t 16). Note that this does not fix the remaining bug in #256 (closed) (Now fixed independently).

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: star_particles