Skip to content

GEAR sink : final chunk from the big MR

Darwin requested to merge darwin/sink_merging into master

This MR splits !1943 (merged) into its last chunk. Here are the changes:

  • We discovered a "bug" when we ran with --enable-debugging-checks with the POP III stars table. The SNIa progenitor mass can be smaller than the IMF mass, and the code crashes. I commented this part while thinking for a better check.
  • I added a star_formation_setters.h file in the GEAR module. I don't want sink particles to modify SF data structures from within the sink module. I prefer to call setters functions.
  • I added an error message when we try to run the code with --sink but without --feedback. If we do the latter, the code crashes because of memory error (feedback data are not initialised). An error is clearer for the users.

Merge request reports