Skip to content

GEAR stars: Move star_type from feedback module to stars

Darwin requested to merge darwin/move_feedback_star_type into master

This attribute (star_type) characterises the star particles, not the feedback. Hence, it should be in the stars module, not the feedback module. This MR implements this.

Advantages:

  • Avoids duplicating the names between GEAR, AGORA, and the new GEAR-mechanical feedback --> more consistent, more manageable (with fewer human errors)
  • Can be used by any modules, e.g. sinks, feedback, SF, RT, e.g. without depending on the GEAR feedback modules --> no feedback module dependence

Todo:

  • Read the value from the initial conditions

Merge request reports