Skip to content

Update thermal AGN feedback field descriptions in the spin-jet model

Filip Husko requested to merge update_spin_jet_field_descriptions into master

As pointed out by @rmcgibbon, many of the AGN-related fields have somewhat ambiguous) descriptions, and it is not clear that they refer to the thermal AGN channel. The reason is that these descriptions were just copied from the branch of the code where there is only 1 AGN channel.

This MR updates some of these thermal fields to explicitly say they're thermal in the outputs (also in the code where they're defined, but that's less of a priority).

Note that some of these fields also have ambiguous names (e.g. NumberOfAGNEvents). Ideally we'd rename this to NumberOfThermalAGNEvents. However, this is probably a very bad time to make such a change. It's better if these fields, that exist in both the thermal-only and hybrid AGN models, have the same name.

Merge request reports