Draft: Velocity dependent term in Dedner evolution

This is still preliminary but perhaps interesting

added MHD label

requested review from @fastasyszyn

assigned to @matthieu

added 1 commit

• 3e44a659 - Temp fix for cloud collapse

Compare with previous version

Todo:

• Cosmology terms
• Run code formatting
• Show before/after plot for the main tests.

approved this merge request

unapproved this merge request

approved this merge request

I agree with @matthieu to justify why the change. Also I notice that it will only work for one definition of Gamma. I suggest to check it in some place and stop the run if the Gamma is not the desired one....

Still waiting to hear back from Daniel about this, to see whether it's a reasonable idea or a no go. Once all other issues in the main testing workflow are fixed (e.g. the weird Alfven Wave business), I'll come back to this and address the concerns you raise bellow, before testing it on all standard examples.

Good.

marked this merge request as draft

changed title from Draft: Veolicty dependent term in Dedner evolution to Draft: Velocity dependent term in Dedner evolution

@okarapiperis I understand that this is no needed?

Shall we close this? Or is it still up in the air? If so, conflicts need fixing.

closed