Skip to content

Move from rt_reset_part to rt_reset_part_each_subcycle.

Tsang Keung Chan requested to merge RT_reset_SPHM1RT_subcycle into master

I am finding that when I turn on sub-cycling with SPHM1RT, the radiation speed increases proportional to the number of sub-cycles. For example, the radiation front move twice faster in Advection_1D if I used the number of sub-cycles=2.

Reason: In SPHM1RT, we do not reset at every sub-cycle, but only at hydro time step. I can solve the issue by moving the content from rt_reset_part to rt_reset_part_each_subcycle.

The performance:

no sub-cycle output_0011-all-quantities_nosub

8 sub-cycle output_0011-all-quantities_8sub

32 sub-cycle output_0011-all-quantities_32sub

@mivkov Note that I also introduce cosmo struct in rt_reset_part_each_subcycle, so I have changed all of the rt module.

To do:

  1. check Stromgren3D for thermo-chemistry (sub-cycling is working, but the reinjection is not working)
  2. check if other schemes still work (GEARRT is working for Advection1D)
Edited by Tsang Keung Chan

Merge request reports