Add mean matter density and BN98 to cosmology module

Also fix a mistake in the spin-jet BH model where the incorrect mean density was used.

added bug feature request labels

requested review from @dc-husk1

assigned to @jch

Thanks for catching the jet velocity scaling and the fix.

I'm not sure the virial radius calculation is correct here. The BN98 delta_c is a multiple of the critical density, so I think the halo density should be cosmo->critical_density*cosmo->overdensity_BN98.

Thanks. You are right.

I copied what was done before the change. Let me fix it.

added 1 commit

• 797ba0b4 - Use the critical density in the spin-jet halo mass calculation and not the mean density

Compare with previous version

merged

mentioned in commit db9b2300