Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • SWIFTsim SWIFTsim
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 57
    • Issues 57
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 21
    • Merge requests 21
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • SWIFT
  • SWIFTsimSWIFTsim
  • Merge requests
  • !1607

Three fixes to the PHANTOM SPH scheme

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Matthieu Schaller requested to merge fix_phantom into master Jul 29, 2022
  • Overview 3
  • Commits 3
  • Changes 1

Fixes #803 (closed).

This introduces three changes to phantom SPH:

  • The du/dt term diffusion was incorrect as it used rho_i twice instead of both rho_i and rho_j.
  • The dh/dt term now uses the same definition as SPHENIX
  • The signal velocity did not use the new function introduced for MHD reasons.

That first point fixes the symmetry test but not sure why we did not catch it before.

The second point fixes the issue #803 (closed). However, what is strange is that we have two different definitions of this term between SPHENIX and minimal (say). The former one does not include the f_ij terms, the latter one does. This term is not super important but it's still a weird difference.

Edited Jul 30, 2022 by Matthieu Schaller
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix_phantom